Repository navigation
feat: asdf -> mise - #1695
Closed
kalverra wants to merge 4 commits into
Closed
feat: asdf -> mise#1695kalverra wants to merge 4 commits into
kalverra wants to merge 4 commits into
Conversation
Contributor
|
👋 kalverra, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
🦋 Changeset is good to goLatest commit: 951fa85 We got this. Not sure what this means? Click here to learn what changesets are. |
The repo's composite actions reference setup-nodejs@setup-nodejs/v1 (released), which reads .tool-versions and falls back to pnpm ^10; deleting the file made every ci-* job fail engines.pnpm=12 with ERR_PNPM_UNSUPPORTED_ENGINE. Keep .tool-versions as a transitional duplicate of mise.toml (inert for mise users) until setup-nodejs v2 ships and internal refs are bumped. Also release setup-nodejs as a major: its input contract changed (auto-detect default, new node-version/mise-install inputs, no-error fallback).
resolve-versions.test.sh (24 cases) and resolve-bun-version.test.sh (20 cases) were never executed in CI, and ci-lint-misc only shellchecks ./tools/scripts. Run both suites and shellcheck the action scripts in the ci-lint-misc job. Remove the temporary continue-on-error bypass for #1470: actionlint and shellcheck are clean on this tree.
kalverra
force-pushed
the
DX-5569/use-mise
branch
from
October 14, 2026 20:54
39cab7e to
77fa99a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miseinstead ofasdf.Stack created with GitHub Stacks CLI • Give Feedback 💬